search

thesis / valkyrie

Valkyrie is our hubot. She guides your requirements to Valhalla, and shields the halls of Thesis.
https://valkyrie.thesis.co
Other
5 stars 5 forks source link

Fix twitter embeds: Use fxtwitter.com to fix embeds for Twitter links #275

Closed Shadowfiend closed 10 months ago

Shadowfiend commented 10 months ago

Includes a couple of small stylistic fixes.

The main commit:

When a new twitter.com/x.com link is seen, Valkyrie auto-replies with the same link switched to fxtwitter.com (see https://github.com/FixTweet/FxTwitter for the implementation). This produces an actual Discord embed, as well as auto-expanding t.co links and doing a couple of other useful things.

Those who wish to can also change the link to always redirect to nitter instead of twitter (e.g. if you do not stay logged in or if twitter is broken for you).

beaurancourt commented 10 months ago

looks good to me; have this hooked up anywhere that i can give it a spin?

beaurancourt commented 10 months ago

ahh, i see you already ran it:

image
beaurancourt commented 10 months ago

okay, I'm good here. Dropped a totally optional denesting suggestion. Merge when you're ready!