theskylander / Skylander-plugins

Skylander VCV rack Development
Creative Commons Zero v1.0 Universal
2 stars 1 forks source link

Fonts stored across frames #2

Closed cschol closed 1 month ago

cschol commented 2 years ago

Fonts are stored across frames, which causes the VST to crash.

Please see this section in the manual for details: https://vcvrack.com/manual/Migrate2#2-1-Don-t-store-Font-and-Image-references-across-multiple-frames

src/UI.hpp
63-     std::shared_ptr<Font> font;
64-
65-     StateDisplay() {
66:             font = APP->window->loadFont(asset::plugin(pluginInstance, "res/EurostileBold.ttf"));
67-     }
68-
69-     void draw(const DrawArgs& args) override {

src/NymphesControl.cpp
913-  std::shared_ptr<Font> font;
914-
915-  VerySmallDisplayWidget() {
916:    font = APP->window->loadFont(asset::plugin(pluginInstance, "res/Segment7Standard.ttf"));
917-  };
918-
919-  void draw(const DrawArgs& args) override
--
966-  std::shared_ptr<Font> font;
967-
968-  DisplayWidget() {
969:    font = APP->window->loadFont(asset::plugin(pluginInstance, "res/Segment7Standard.ttf"));
970-  };
971-
972-  void draw(const DrawArgs& args) override
ashoward commented 2 years ago

should be fixed now. apologies for missing that in the migration manual.