UrsulPolar
commented
1 year ago Hello!
Though I'm not a programmer, or an expert in anything that has to do with codecs or C coding, I've written the following, having as a starting point a code written by someone else, and adjusted to have the system change the output to the headphones / speakers on jack connect for our lovely MateBooks... I also need to mention @anticodeninja and @DmitriiMukhin for the hints with regards to the proper verbs to be used. I stuck with SET_EAPD_BTLENABLE (0x70c) and SET_CONNECT_SEL (0x701) for the HP/SPKR nodes.
- Speaker output works, internal mics are unaffected (working).
- Wired headphones work having the headphone mic detected and usable.
I refactored the code quite a bit and seems to be an usable solution. It properly resumes from suspend
/* * File: huawei_matebook14s_codec_fix.cpp * Author: ursul_polar * * Created on Apr 09, 2023, 9:19 PM */ #include <iostream> #include <fcntl.h> #include <unistd.h> #include <syslog.h> #include <sys/ioctl.h> #include <memory> #include <signal.h>
// Class to handle file descriptor class FileDescriptor { public: explicit FileDescriptor(const char* path, int flags) { fd = open(path, flags); if (fd < 0) { syslog(LOG_ERR, "Failed to open file %s", path); throw std::runtime_error("Failed to open file"); } }
~FileDescriptor() {
close(fd_);
}
operator int() const {
return fd_;
}
private:
int fd_;};
typedef uint32_t u32;
// Headphones connection enum enum HDAConnectionState { HEADPHONES_CONNECTED = 8, HEADPHONES_DISCONNECTED = 0 };
define HDA_VERB(nid, verb, param) ((nid) << 24 | (verb) << 8 | (param))
define HDA_IOCTL_VERB_WRITE _IOWR('H', 0x11, struct hda_verb_ioctl)
define SPEAKER_VERBS_COUNT 3
const u32 speaker_verbs[SPEAKER_VERBS_COUNT] = { HDA_VERB(0x16, 0x701, 0x0001), HDA_VERB(0x17, 0x70C, 0x0002), HDA_VERB(0x1, 0x715, 0x2) };
define HEADPHONES_VERBS_COUNT 5
const u32 headphones_verbs[HEADPHONES_VERBS_COUNT] = { HDA_VERB(0x16, 0x701, 0x0000), HDA_VERB(0x17, 0x70C, 0x0000), HDA_VERB(0x1, 0x717, 0x2), HDA_VERB(0x1, 0x716, 0x2), HDA_VERB(0x1, 0x715, 0x0) };
// Define HDA verb ioctl struct struct hda_verb_ioctl { u32 verb; u32 res; };
// Define path to HDA device file
define HW_PATH_FD "/dev/snd/hwC0D0"
// Open HDA device file and return file descriptor wrapped in a unique_ptr
std::unique_ptr
// Get the connection state of the headphones int get_headphones_connection_state() { auto fd = open_hda_device_file(); hda_verb_ioctl state_check = { .verb = HDA_VERB(0x16, 0x0f09, 0x0) }; if (ioctl(*fd, HDA_IOCTL_VERB_WRITE, &state_check) < 0) { syslog(LOG_ERR, "Failed to send verb ioctl to HDA device file."); exit(EXIT_FAILURE); } return (state_check.res >> 31) & 1; }
// Set the connection state of the speakers void set_speaker_connection_state(bool connected) { auto fd = open_hda_device_file(); const u32 verbs = connected ? speaker_verbs : headphones_verbs; const int verb_count = connected ? SPEAKER_VERBS_COUNT : HEADPHONES_VERBS_COUNT; for (int i = 0; i < verb_count; i++) { hda_verb_ioctl verb = { .verb = verbs[i] }; if (ioctl(fd, HDA_IOCTL_VERB_WRITE, &verb) < 0) { syslog(LOG_ERR, "Failed to send verb ioctl to HDA device file."); exit(EXIT_FAILURE); } syslog(LOG_INFO, "Written data to hda verb 0x%.8x", verb); } }
bool should_exit = false;
void signal_handler(int signum) { if (signum == SIGCONT) { syslog(LOG_INFO, "Received SIGCONT signal, exiting loop"); should_exit = true; } }
int main() { // Register signal handler for SIGCONT struct sigaction sig_action; sig_action.sa_handler = &signal_handler; sigemptyset(&sig_action.sa_mask); sig_action.sa_flags = 0; if (sigaction(SIGCONT, &sig_action, nullptr) < 0) { syslog(LOG_ERR, "Failed to register signal handler for SIGCONT"); exit(EXIT_FAILURE); }else{ syslog(LOG_INFO, "Successfully registered signal handler"); }
// Set initial connection state
int state = 8;
while(!should_exit){
int current_state = get_headphones_connection_state();
if(state != current_state){
// Set speakers to connected or disconnected based on current state of headphones
set_speaker_connection_state(current_state == HEADPHONES_DISCONNECTED);
state = current_state;
}
sleep(1);
}
return 0;}
I've compiled the code with `gcc` while having ` gcc-c++` installed. The executable was moved in `/usr/local/bin`.
```text
$ gcc huawei_matebook14s_codec_fix.cpp -lstdc++ -o huawei-codec-fix
# mv huawei-codec-fix /usr/local/bin/To have it used by a service a file was created in /etc/systemd/system/huawei-codec-fix.service.
# cat << EOF > /etc/systemd/system/huawei-codec-fix.service
[Unit]
Description=huawei-codec-fix
Before=sleep.target
StopWhenUnneeded=yes
[Service]
Type=idle
ExecStart=/usr/local/bin/huawei-sound-fix
RemainAfterExit=yes
[Install]
WantedBy=multi-user.target suspend.target hibernate.target hybrid-sleep.target sleep.target
EOFOn Fedora 37, in order to have the service file detected by systemd and the permission for systemd to run the executable that we just created we need to make use of restorecon.
# /usr/sbin/restorecon -rv /etc/systemd/system/huawei-codec-fix.service
# /usr/sbin/restorecon -rv /usr/local/bin/huawei-codec-fixAfter this we can proceed with loading, enabling and starting the service.
# systemctl daemon-reload
# systemctl enable huawei-codec-fix.service
# systemctl start huawei-codec-fix.serviceIt writes to logs if it's unable to get control of the device or if a change occurs. You can see the state of the service with:
# systemctl status huawei-codec-fix.serviceor the insignificant logs with:
# journalctl -xeu huawei-codec-fixIt's obvious that you can choose another name for the file/service.
I know it's not a proper fix, but hope it helps.
Jan 22 09:34:32 MateBook14s systemd[1]: Started huawei-codec-fix.service - huawei-codec-fix.
░░ Subject: A start job for unit huawei-codec-fix.service has finished successfully
░░ Defined-By: systemd
░░ Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
░░
░░ A start job for unit huawei-codec-fix.service has finished successfully.
░░
░░ The job identifier is 12631.
Jan 22 09:34:32 MateBook14s huawei-codec-fix[40371]: Daemon started.
Jan 22 09:34:33 MateBook14s huawei-codec-fix[40371]: Enabled headphone output
Jan 22 09:41:46 MateBook14s huawei-codec-fix[40371]: Enabled speaker output
Jan 22 09:43:46 MateBook14s huawei-codec-fix[40371]: Enabled headphone output
Jan 22 09:44:06 MateBook14s huawei-codec-fix[40371]: Enabled speaker output
Jan 22 09:44:20 MateBook14s huawei-codec-fix[40371]: Enabled headphone output
Jan 22 10:06:26 MateBook14s systemd[1]: Stopping huawei-codec-fix.service - huawei-codec-fix...
░░ Subject: A stop job for unit huawei-codec-fix.service has begun execution
░░ Defined-By: systemd
░░ Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
░░
░░ A stop job for unit huawei-codec-fix.service has begun execution.
░░
░░ The job identifier is 12877.
Jan 22 10:06:26 MateBook14s systemd[1]: huawei-codec-fix.service: Deactivated successfully.
░░ Subject: Unit succeeded
░░ Defined-By: systemd
░░ Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
░░
░░ The unit huawei-codec-fix.service has successfully entered the 'dead' state.
Jan 22 10:06:26 MateBook14s huawei-codec-fix[40371]: Daemon stopped.
Jan 22 10:06:26 MateBook14s systemd[1]: Stopped huawei-codec-fix.service - huawei-codec-fix.
░░ Subject: A stop job for unit huawei-codec-fix.service has finished
░░ Defined-By: systemd
░░ Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
░░
░░ A stop job for unit huawei-codec-fix.service has finished.
░░
░░ The job identifier is 12877 and the job result is done.Evidently, if anyone notices something that is not proper in the code or has the option to improve it, feel free to do so.
spacer2010
xalexalex
doom-fr
maniadevice
RobertPietraru
florian-sabonchi
GeorgeKarles
cihatertem
foofly
phanky5
izheynes
Smoren
tikhcloud
thule1291
merelm-academy
eniskastrati
Cypukat85
vpkopylov
developersu
NikitaMarakushev
catmeowjiao
Fisherworks
I tried different distros Ubuntu 21.10/Fedora and now Arch linux. I have an issue with speaker, headphone settings. First of all the laptop has 4 speakers and 4 dijital mics. Well these are problems: 1) Gnome volume slider does not effect on volume. Each clicks give same beep until below %5 and volume goes down. 2) If I plug a headphone, no sound at headphone and sound still comes from speakers. And after unplugged the headphone, speakers go mutted! 3) To unmut the speakers I have to go alsamixer and select sound card 'sof-hda-dsp' (codec Chip: Conexant CX8070 ) and then I have to unmut headphone 4) I can set speaker's volume from alsamixer's headphone slider. Speaker slider has no effect, Master slider only effect depends on headphone slider point.
Environment 1) Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
I tried several model=NAME options but there is no result. Here they are, installed alsa packages with sof-bin: alsa-card-profiles, alsa-firmware, alsa-lib, alsa-plugins, alsa-topology-conf, alsa-ucm-conf, alsa-utils, pulseaudio-alsa, zita-alsa-pcmi, sof-firmware, sof-tools
If you need more log, outputs, please lead me :)