search

thesofproject / linux

Linux kernel source tree
Other
91 stars 133 forks source link

missing MODULE_DESCRIPTION #4988

Closed plbossart closed 6 months ago

plbossart commented 6 months ago

make W=1 now complains about missing MODULE_DESCRIPTION() It can also be shown with this hack:

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 2f5b91da5afa..f2f72d38e700 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1654,8 +1654,8 @@ static void read_symbols(const char *modname)
                }
        }

-       if (extra_warn && !get_modinfo(&info, "description"))
-               warn("missing MODULE_DESCRIPTION() in %s\n", modname);
+       if (!get_modinfo(&info, "description"))
+               error("missing MODULE_DESCRIPTION() in %s\n", modname);
        for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {
                symname = remove_dot(info.strtab + sym->st_name);
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-intel-atom.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-byt.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-bdw.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-intel-hda-common.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-intel-hda-generic.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-intel-hda-mlink.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-intel-hda.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-pci-intel-tng.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-pci-intel-skl.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-pci-intel-apl.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-pci-intel-cnl.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-pci-intel-icl.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-pci-intel-tgl.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-pci-intel-mtl.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-pci-intel-lnl.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-utils.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-acpi.o
ERROR: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-pci.o
plbossart commented 6 months ago

added by https://github.com/thesofproject/linux/pull/4989