thesofproject / linux

Linux kernel source tree
Other
88 stars 128 forks source link

Fixup! ASoC: Intel: sof_sdw_rt_sdca_jack_common: remove -sdca for new… #4991

Closed ujfalusi closed 2 weeks ago

ujfalusi commented 3 weeks ago

… codecs

Match against the correct string to decide to add the '-sdca' postfix: instead of codec_dai->name the correct one is component->name_prefix

For rt713 on a Dell MTL laptop: component->name_prefix : rt713 codec_dai->name : rt712-sdca-aif1

or

add the rt712 to the need_sdca_suffix[] array?

bardliao commented 3 weeks ago

Thanks @ujfalusi. Indeed, we should use component->name_prefix instead of codec_dai->name

plbossart commented 3 weeks ago

I already sent the initial code to Mark Brown btw, so this might need to come as a regular commit with a Fixes: tag.

ujfalusi commented 3 weeks ago

I already sent the initial code to Mark Brown btw, so this might need to come as a regular commit with a Fixes: tag.

I see, they are not picked yet, so I need to wait for the SHA from linux-next then.

plbossart commented 3 weeks ago

they were picked this morning,

9a9d31b149f3 ASoC: Intel: sof_sdw_rt_sdca_jack_common: remove -sdca for new codecs

ujfalusi commented 2 weeks ago

Changes since v1:

plbossart commented 2 weeks ago

@ujfalusi can you send this to linux-sound cc: Mark Brown? This need to go in a 6.10-rc fix, thanks.