search

thesofproject / linux

Linux kernel source tree
Other
91 stars 133 forks source link

AMD SOF based generic SoundWire machine driver #5034

Closed vijendarmukunda closed 5 months ago

vijendarmukunda commented 6 months ago

This patch series is rebase version of https://github.com/thesofproject/linux/pull/5017.

vijendarmukunda commented 6 months ago

@plbossart : could you please review the patch series?

plbossart commented 5 months ago

you may want to fix those warnings. They were probably in the initial code.

WARNING: struct snd_soc_ops should normally be const
#557: FILE: sound/soc/intel/boards/sof_sdw_common.h:168:
+extern struct snd_soc_ops soc_sdw_rt1308_i2s_ops;

WARNING: struct snd_soc_ops should normally be const
#936: FILE: sound/soc/intel/boards/sof_sdw_rt_amp.c:236:
+struct snd_soc_ops soc_sdw_rt1308_i2s_ops = {
vijendarmukunda commented 5 months ago

you may want to fix those warnings. They were probably in the initial code.

WARNING: struct snd_soc_ops should normally be const
#557: FILE: sound/soc/intel/boards/sof_sdw_common.h:168:
+extern struct snd_soc_ops soc_sdw_rt1308_i2s_ops;

WARNING: struct snd_soc_ops should normally be const
#936: FILE: sound/soc/intel/boards/sof_sdw_rt_amp.c:236:
+struct snd_soc_ops soc_sdw_rt1308_i2s_ops = {

These warnings fix was taken care after moving the code to sdw_utils folder.

vijendarmukunda commented 5 months ago

you may want to fix those warnings. They were probably in the initial code.

WARNING: struct snd_soc_ops should normally be const
#557: FILE: sound/soc/intel/boards/sof_sdw_common.h:168:
+extern struct snd_soc_ops soc_sdw_rt1308_i2s_ops;

WARNING: struct snd_soc_ops should normally be const
#936: FILE: sound/soc/intel/boards/sof_sdw_rt_amp.c:236:
+struct snd_soc_ops soc_sdw_rt1308_i2s_ops = {

Fixed check patch warning.

plbossart commented 5 months ago

sorry @vijendarmukunda both @bardliao and I are busy with other issues, we'll look into this when we have more time. Thanks for your understanding.