search

thesofproject / linux

Linux kernel source tree
Other
91 stars 133 forks source link

ASoC: amd: acp: fix for unused-but-set-variable warning for amp_num #5107

Closed vijendarmukunda closed 4 months ago

vijendarmukunda commented 4 months ago

'amp_num' will be used to create card component name for amp configuration. Earlier this assignment was missing which resulted in below warning.

sound/soc/amd/acp/acp-sdw-sof-mach.c:644:6: warning: variable 'amp_num' set but not used [-Wunused-but-set-variable] 644 | int amp_num = 0, i; | ^

Fixes: 8245a1411fef ("ASoC: amd/sdw_utils: add sof based soundwire generic machine driver") Reported-by: kernel test robot lkp@intel.com Closes: https://lore.kernel.org/oe-kbuild-all/202407160447.9KCzYnRz-lkp@intel.com/

vijendarmukunda commented 4 months ago

usually we use a fixup! prefix when it's a correction to something that's not been upstreamed yet. Likewise we don't add Fixes: tag because the commit ID only exists in the SOF tree, and it'll be different when applied by Mark Brown.

got it i will correct the commit mesage.