search

thesofproject / linux

Linux kernel source tree
Other
91 stars 133 forks source link

Add match entries for a bunch of coming cs42l43 laptop SKUs #5130

Closed charleskeepax closed 3 months ago

bardliao commented 4 months ago

sounds good but don't we also need the machine driver quirks?

@plbossart I think quirks is needed only if cs42l43 speaker is used or cs42l43 works as bridge mode.

charleskeepax commented 4 months ago

Yeah some quirks will need to be added, but I am being a little more cautious with sending up the quirks as they depend on the SSID and as we found out with the last set sometimes those aren't as locked down as I thought. Where as these bus layouts are locked down pretty early.

plbossart commented 3 months ago

@charleskeepax @bardliao are all the topologies listed in this PR part of the SOF tree now?

Confused about this PR https://github.com/thesofproject/sof/pull/9355 which is still a draft ....

bardliao commented 3 months ago

@charleskeepax @bardliao are all the topologies listed in this PR part of the SOF tree now?

Confused about this PR thesofproject/sof#9355 which is still a draft ....

This is a draft because it has not been tested on the actual device, yet.

charleskeepax commented 3 months ago

Most of these are missing actually topologies yet, do you generally prefer to merge the topologies before the match entries? I could probably put a patch together although I don't have hardware to test most of them.

plbossart commented 3 months ago

it's usually better to merge and send this stuff upstream due to the development process, the patches will not be in Linus' tree before end of the year. But we do want to avoid misses in topology and make sure the sof-bin stuff does have the topologies ready. This is best tracked with a Sof GitHub/topology issue and a milestone.