search

thesofproject / linux

Linux kernel source tree
Other
91 stars 134 forks source link

ASoC/soundwire: Add rt712 VB support #5199

Closed bardliao closed 1 month ago

bardliao commented 1 month ago

Lookup SDCA functions and version to identify rt712/rt713 B version. This PR is from https://github.com/thesofproject/linux/pull/5128

vijendarmukunda commented 1 month ago

@bardliao : I do have one question. When can we expect SDCA 1.0 migration support related patches going to land in kernel mainline. Any ETA planned for the same? We also want to validate these changes with AMD SoundWire stack.

bardliao commented 1 month ago

@bardliao : I do have one question. When can we expect SDCA 1.0 migration support related patches going to land in kernel mainline. Any ETA planned for the same? We also want to validate these changes with AMD SoundWire stack.

Sorry @vijendarmukunda I didn't get your question. What are "SDCA 1.0 migration support related patches"? Is there anything we missed for supporting SDCA codecs?

vijendarmukunda commented 1 month ago

@bardliao : I do have one question. When can we expect SDCA 1.0 migration support related patches going to land in kernel mainline. Any ETA planned for the same? We also want to validate these changes with AMD SoundWire stack.

Sorry @vijendarmukunda I didn't get your question. What are "SDCA 1.0 migration support related patches"? Is there anything we missed for supporting SDCA codecs?

@bardliao : As per my understanding, Current codec drivers supports SDCAv0.6 version. If I understand correctly SDCAv1.0 expects all descriptors and peripheral topology entries will be part of ACPI tables. Even peripheral register blind write table will also be part of ACPI table unlike SDCAv0.6 version based codec driver where tables are listed in driver source code. As you are working on adding sdca helpers to read from ACPI tables, i thought going forward peripheral devices will conformant with SDCA 1.0. Please correct me, if my understanding is wrong.

charleskeepax commented 1 month ago

I think perhaps that sort of framing is coming more from the Windows side of the world. From the Linux kernel side we should just be supporting both versions as there are parts in the wild using both. The new code being added here doesn't really change any of the existing support however and there is basically no SDCA support currently in the kernel, this is really the first part.

bardliao commented 1 month ago

@bardliao : I do have one question. When can we expect SDCA 1.0 migration support related patches going to land in kernel mainline. Any ETA planned for the same? We also want to validate these changes with AMD SoundWire stack.

Sorry @vijendarmukunda I didn't get your question. What are "SDCA 1.0 migration support related patches"? Is there anything we missed for supporting SDCA codecs?

@bardliao : As per my understanding, Current codec drivers supports SDCAv0.6 version. If I understand correctly SDCAv1.0 expects all descriptors and peripheral topology entries will be part of ACPI tables. Even peripheral register blind write table will also be part of ACPI table unlike SDCAv0.6 version based codec driver where tables are listed in driver source code. As you are working on adding sdca helpers to read from ACPI tables, i thought going forward peripheral devices will conformant with SDCA 1.0. Please correct me, if my understanding is wrong.

I got your question now @vijendarmukunda. Yes, we are working on SDCA library. However, there is no ETA so far. The SDCA 1.0 codecs will use their own codec drivers like what we do today. We could work together on the SDCA library :)

bardliao commented 1 month ago

SOFCI TEST

vijendarmukunda commented 1 month ago

@bardliao : I do have one question. When can we expect SDCA 1.0 migration support related patches going to land in kernel mainline. Any ETA planned for the same? We also want to validate these changes with AMD SoundWire stack.

Sorry @vijendarmukunda I didn't get your question. What are "SDCA 1.0 migration support related patches"? Is there anything we missed for supporting SDCA codecs?

@bardliao : As per my understanding, Current codec drivers supports SDCAv0.6 version. If I understand correctly SDCAv1.0 expects all descriptors and peripheral topology entries will be part of ACPI tables. Even peripheral register blind write table will also be part of ACPI table unlike SDCAv0.6 version based codec driver where tables are listed in driver source code. As you are working on adding sdca helpers to read from ACPI tables, i thought going forward peripheral devices will conformant with SDCA 1.0. Please correct me, if my understanding is wrong.

I got your question now @vijendarmukunda. Yes, we are working on SDCA library. However, there is no ETA so far. The SDCA 1.0 codecs will use their own codec drivers like what we do today. We could work together on the SDCA library :)

@bardliao: Thanks

bardliao commented 1 month ago

@ujfalusi header include orders fixed.