search

thesofproject / qemu

Official QEMU mirror. Please see http://wiki.qemu.org/Contribute/SubmitAPatch for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. SOF - Please use sof-stable branch for SOF development.
http://www.qemu.org
Other
4 stars 14 forks source link

ext_man: Skip extended manifest in fw loading routine #36

Closed ktrzcinx closed 4 years ago

ktrzcinx commented 4 years ago

There is no need to parse extended manifest in quemu at this moment, so it should be skipped to allow successfully fw load.

Signed-off-by: Karol Trzcinski karolx.trzcinski@linux.intel.com

lgirdwood commented 4 years ago

@xiulipan can you update the CI container with this update. Thanks !

xiulipan commented 4 years ago

@lgirdwood build errors here. I will try to add a Travis build check for QEMU project.

/home/sof/qemu/hw/adsp/dsp/common.c: In function 'adsp_get_ext_man_size':
/home/sof/qemu/hw/adsp/dsp/common.c:310:15: error: 'SOF_EXT_MAN_MAGIC_NUMBER' undeclared (first use in this function); did you mean 'SND_SOF_EXT_MAN_MAGIC_NUMBER'?
  if (fw[0] == SOF_EXT_MAN_MAGIC_NUMBER)
               ^~~~~~~~~~~~~~~~~~~~~~~~
               SND_SOF_EXT_MAN_MAGIC_NUMBER
/home/sof/qemu/hw/adsp/dsp/common.c:310:15: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [hw/adsp/dsp/common.o] Error 1
/home/sof/qemu/rules.mak:69: recipe for target 'hw/adsp/dsp/common.o' failed
make: *** [xtensa-softmmu/all] Error 2
lgirdwood commented 4 years ago

@ktrzcinx build errors ? Are we missing a header or macro in your PR ?

ktrzcinx commented 4 years ago

Oh, I'm sorry, I renamed macro name before pushing, but only in a few places. Fix is in https://github.com/thesofproject/qemu/pull/37