search

thesofproject / rimage

DSP firmware image creation and signing tool
Other
7 stars 62 forks source link

Convert all ELF addresses to cached for calculations #126

Closed lyakh closed 1 year ago

lyakh commented 1 year ago

Rimage calculates sizes of ELF sections, for which it has to use addresses from the same address space: either all cached or all uncached. The ELF image itself can contain mixed addresses. Convert all to cached for internal calculations.

paulstelian97 commented 1 year ago

Merge commit, which I'd consider a mess. That said I don't know if the rule that rebase must be preferred to merge also applies to this repo.

lyakh commented 1 year ago

Merge commit, which I'd consider a mess. That said I don't know if the rule that rebase must be preferred to merge also applies to this repo.

@paulstelian97 sorry, I should've marked this a draft while resolving the conflict properly. Fixed now

lyakh commented 1 year ago

If this method is acceptable, I'll add other platforms too

lyakh commented 1 year ago

addresses https://github.com/thesofproject/sof/issues/6741

lyakh commented 1 year ago

I marked it "ready for review" to actually have it reviewed, but before merging or at least before updating SOF to use the updated rimage, we have to add all other platforms too

lgirdwood commented 1 year ago

@lyakh is there a Zephyr PR for removal of the python script or do we need other SOF PRs merged first ?

lyakh commented 1 year ago

@lyakh is there a Zephyr PR for removal of the python script or do we need other SOF PRs merged first ?

@lgirdwood we can merge this first. As we see, all tests pass. Running that .py script on top of this change shouldn't hurt. After this is merged then we can remove that python script

lgirdwood commented 1 year ago

@lyakh just a few review comments then we are good.