Closed lyakh closed 1 year ago
@kv2019i fyi.
This one passed testing too: https://github.com/thesofproject/sof/pull/7062 (before the addition of the 2nd commit though)
https://github.com/thesofproject/sof/pull/7062 relaunched and passed all tests with both commits too
@lyakh this still fails with xtos builds.
@lyakh nice try but I think your test PR https://github.com/thesofproject/sof/pull/7062 did not work because it updated the west manifest only, not the submodules. See comment in sof/west.yml.
We must decouple submodules and west but this will be somewhat disruptive for CIs and there's always some higher priority than breaking CI. Maybe after 2.5
@lyakh nice try but I think your test PR thesofproject/sof#7062 did not work because it updated the west manifest only, not the submodules. See comment in sof/west.yml.
We must decouple submodules and west but this will be somewhat disruptive for CIs and there's always some higher priority than breaking CI. Maybe after 2.5
@marc-hb yes, thanks, we figured it out last week, trying to fix it for all configurations...
A recent commit ec649f37d661 ("Convert all ELF addresses to cached for calculations") had a bug: it assumed a call to parse_uint32_hex_key() for an absent key would return an error by default, which isn't the case. To force it set the default return code to an error value.