search

thesofproject / rimage

DSP firmware image creation and signing tool
Other
7 stars 62 forks source link

mtl: remove smart amp config in basefw #185

Closed RanderWang closed 12 months ago

RanderWang commented 1 year ago

Smart amp will be a loadable module.

RanderWang commented 1 year ago

@kv2019i is this branch correct ? thanks!

lgirdwood commented 1 year ago

@RanderWang @kv2019i should we be pushing PRs here now that @marc-hb has upstreamed into sof repo ? I can park this repo if ready now ?

mengdonglin commented 1 year ago

@RanderWang @kv2019i should we be pushing PRs here now that @marc-hb has upstreamed into sof repo ? I can park this repo if ready now ?

@lgirdwood This is for making dummy smart amp loadable for mtl-006 only, as mtl-006 is still using this separate rimage. This is not for SOF main branch where loadable module support is not available.

pjdobrowolski commented 1 year ago

You can load any loadable module on sof main only if it use standard native system service.

mengdonglin commented 1 year ago

I think the SOF mtl-006 branch should use a new rimage mtl-006 branch, not the rimage main branch.

@marc-hb The rimage mtl-006 branch already exists for previous mtl-006 FW release. Current PR is for https://github.com/thesofproject/rimage/tree/mtl-006-drop-stable, not the main rimage branch of rimage.

marc-hb commented 12 months ago

My bad sorry. I keep missing the target branch all the time.