search

thesofproject / rimage

DSP firmware image creation and signing tool
Other
7 stars 62 forks source link

[stable-v2.7] config/lnl.toml: drop now invalid signed_pkg.partition_usage #190

Closed marc-hb closed 11 months ago

marc-hb commented 11 months ago

Fixes commit fbea59358d06 ("rimage: mtl: fix key slot setup based on imr type") which broke LNL compilation like this:

error: 1 unparsed keys left in 'signed_pkg'
error: key 'signed_pkg' parsing error

Of course LNL is never going to be released on this stable-v2.7 branch but this one-line fix is just the smallest and simplest fix to keep everything building and green. It also keeps everything simple and consistent.

This commit does not change the final image (compared to before rimage commit fbea59358d06) because the default value is now 0x20 + IMR type.

Fixes are normally submitted to the main branch first and then cherry picked to stable branches. However fbea59358d06 has been made in stable-v2.7 first so make this change also in stable-v2.7 first for consistency.

marc-hb commented 11 months ago

Successfully tested in sof/stable-v2.7 https://github.com/thesofproject/sof/actions/runs/6672554043/job/18136695980?pr=8410

Github Actions all green thanks to this.