Closed cujomalainey closed 1 year ago
WIP, just figured i would share as an FYI
Is this missing the "checkout" action?
very likely, this was a copy paste refactor when I was doing the cppcheck work and haven't touched it in a few weeks, looking to land it soon.
@marc-hb feel free to ignore pushes till i mark ready for review, just running tests
@marc-hb i am at a loss for why checkpatch is not working properly, locally when i run the same command it performs the check on only my patch as expected, but in CI it seems to check the whole repo, any guesses what is going on?
@cujomalainey getting checkpatch to work with shallow commits is tricky. It looks like you're copied some old checkpatch Action from SOF. You can either copy the more recent one at https://github.com/thesofproject/sof/blob/main/.github/workflows/shallowfetchPRcommits.sh (starting at https://github.com/thesofproject/sof/pull/3899)
Alternatively, simply disable shallow clones and run checkpatch -g
normally, like you would in your workspace. This repo is small and shallow clones are overkill for it.
@cujomalainey getting checkpatch to work with shallow commits is tricky. It looks like you're copied some old checkpatch Action from SOF. You can either copy the more recent one at https://github.com/thesofproject/sof/blob/main/.github/workflows/shallowfetchPRcommits.sh (starting at thesofproject/sof#3899)
Alternatively, simply disable shallow clones are run
checkpatch -g
normally, like you would in your workspace. This repo is small and shallow clones are overkill for it.
disabling shallow clone did the trick! thanks
@cujomalainey @marc-hb any resolution here ?
I have AIs, I just need to find time to do them
@cujomalainey , if you still don't have the time, maybe @aborisovich could take over?
It looks like https://github.com/actions/virtual-environments offers some Windows environments too.
@marc-hb works for me, we had a re-org right after I started this and I have not had as much time to work upstream as I have wanted since then.
@marc-hb I am starting next week work related to IPC/IDC Zephyr API usage and concept of a refactored build system that would allow seamlessly build SOF+Zephyr on both Linux and Windows for some platforms will be unfinished. I'm drowning in work for now.
I understand, thx.
On the other hand, I found Github Actions the best to test build system changes.
Eh, 12months later and it still rebases cleanly. Apologies for abandoning this
@cujomalainey good to target for v2.5 ?
Can't make any promises, this is pretty low on my priority list unfortunately
@marc-hb @lgirdwood all green, I think this is FINALLY ready to go. Then we can remove any travis hooks left.
We removed them from the main repo, lets remove them here too.
Signed-off-by: Curtis Malainey cujomalainey@chromium.org