thesofproject / rimage

DSP firmware image creation and signing tool
Other
7 stars 62 forks source link

[RFC] rimage: add functionality to resign fw image #76

Closed juimonen closed 2 years ago

juimonen commented 2 years ago

Add function to resign already signed images. This can be done with switch "q" as follows:

"rimage -q sof-tgl.ri -o sof-tgl-mod.ri -c tgl.toml -k key.pem"

Signed-off-by: Jaska Uimonen jaska.uimonen@linux.intel.com

lgirdwood commented 2 years ago

Will wait as discussed for the manifest check to be included in PR

marc-hb commented 2 years ago

@juimonen it looks like this PR added a lot of clang warnings (found by mere chance)

sof/rimage/src/manifest.c:1467:6: error: variable 'buffer' is used uninitialized whenever 'if' condition is true
      [-Werror,-Wsometimes-uninitialized]
        if (ret < 0) {
            ^~~~~~~
sof/rimage/src/manifest.c:1552:7: note: uninitialized use occurs here
        free(buffer);
             ^~~~~~
sof/rimage/src/manifest.c:1467:2: note: remove the 'if' if its condition is always false
        if (ret < 0) {
        ^~~~~~~~~~~~~~
sof/rimage/src/manifest.c:1459:6: error: variable 'buffer' is used uninitialized whenever 'if' condition is true
      [-Werror,-Wsometimes-uninitialized]
        if (size < 0) {
            ^~~~~~~~
sof/rimage/src/manifest.c:1552:7: note: uninitialized use occurs here
        free(buffer);
             ^~~~~~
sof/rimage/src/manifest.c:1459:2: note: remove the 'if' if its condition is always false
        if (size < 0) {
        ^~~~~~~~~~~~~~~
sof/rimage/src/manifest.c:1451:6: error: variable 'buffer' is used uninitialized whenever 'if' condition is true
      [-Werror,-Wsometimes-uninitialized]
        if (ret < 0) {
            ^~~~~~~
sof/rimage/src/manifest.c:1552:7: note: uninitialized use occurs here
        free(buffer);
             ^~~~~~
sof/rimage/src/manifest.c:1451:2: note: remove the 'if' if its condition is always false
        if (ret < 0) {
        ^~~~~~~~~~~~~~
sof/rimage/src/manifest.c:1438:14: note: initialize the variable 'buffer' to silence this warning
        void *buffer;
                    ^
                     = NULL