Closed mengdonglin closed 2 years ago
LGTM, but I suggest two things:
compile sof firmware, and read the firmware with sof_ri_info tool to check if the sof_micro number is really there Thanks for the reminder :) I've checked this. With this PR and SOF CMake update, sof_ri_info.py can show the micro version properly. Here is the test result: For v2.1-rc1: cavs0015 (ADSP Manifest) file offset 0x2300 name ADSPFW build ver 2.1.0.1 feature mask 0xffff image flags 0x0 For v2.1.1: cavs0015 (ADSP Manifest) file offset 0x2300 name ADSPFW build ver 2.1.1.1 feature mask 0xffff image flags 0x0
compile sof firmware, and put it to windows to see if there is any error. I think this will need your help and confirmation from @RanderWang Thank you!
@mengdonglin rimage submodule will need an update PR for sof. Thanks
@mengdonglin rimage submodule will need an update PR for sof. Thanks
@lgirdwood Thank you! I submitted PR https://github.com/thesofproject/sof/pull/5791 to update rimage submodule commit for SOF. Please review.
Fix https://github.com/thesofproject/rimage/issues/90 This is v2 of https://github.com/thesofproject/rimage/pull/91
SOF CMake can extract FW file version from latest git tag and defines SOF_MAJOR, SOF_MINOR and SOF_MICRO for 3 version fields. But rimage only gets major and minor version from SOF CMake and writes them into the standard firmware manifest header of cAVS platforms.
This patch make rimage also get the micro version from SOF CMake, and write it to the unused hotfix_version field of manifest header.
This update will enable sof_ri_info.py to dump entire file version from a FW binary for cAVS platforms. So we can check if a FW release candidate is built from the correct git tag.
Updates from v1: