search

thesofproject / rimage

DSP firmware image creation and signing tool
Other
7 stars 62 forks source link

Tgl h ipc4 toml #98

Closed juimonen closed 2 years ago

juimonen commented 2 years ago

needed: https://github.com/thesofproject/sof/pull/5946

juimonen commented 2 years ago

You have the openssl3.0 guards in the same PR. Plus some notes on the tgl-h specifics.

aah tired..... yes now removed

fredoh9 commented 2 years ago

hmm... when I click 'force-pushed' link, I do see additional change on src/pkcs1_5.c. Something wrong with the diff?

@juimonen juimonen force-pushed the tgl_h_ipc4_toml branch from 80b497f to 570fd34 1 hour ago

fredoh9 commented 2 years ago

Never mind above my comment, I didn't think about rebase and push

marc-hb commented 2 years ago

I do see additional change on src/pkcs1_5.c.

My favorite git topic! :-)

That's because github does not support git range-diff. To see the real difference you can fetch and run git range-diff locally, see demo below.

The other, better workaround is to NOT rebase on force-push. Unless there are conflicts rebasing is pointless and noisy because Github and CI do a merge anyway. You can see that merge with git fetch origin pull/98/merge.


git fetch origin 80b497f5abd933932456e22775740ad61c5ed661
git tag _sof98_1 80b497f5abd933932456e22775740ad61c5ed661

git fetch origin 570fd341cee1208e58c9d499abcf3d62673864e0
git tag _sof98_2 570fd341cee1208e58c9d499abcf3d62673864e0

git range-diff _sof98_1..._sof98_2
1:  73a9d7c897d3 < -:  ------------ rimage: fix openssl 3.0 support in ver25 signing
2:  5e599a23ac62 < -:  ------------ rimage: ace signing functions need openssl 3.0 guards
3:  80b497f5abd9 ! 1:  570fd341cee1 toml: add tgl-h config file for IPC4
    @@ config/tgl-h-cavs.toml (new)
     +
     +[adsp]
     +name = "tgl"
    -+image_size = "0x1F0000"
    ++image_size = "0x1F0000" # (30 + 1) bank * 64KB
     +
     +[[adsp.mem_zone]]
     +type = "ROM"

Gerrit implemented git range-diff years ago, see demo at: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/346001/25..26/drivers/gpu/drm/i915/intel_display.c

Gitlab did not yet https://gitlab.com/gitlab-org/gitlab/-/issues/24096

lgirdwood commented 2 years ago

@juimonen I assume you can send another PR for rimage to sof ?