search

thesofproject / sof-docs

Documentation for SOF
Other
18 stars 73 forks source link

Algorithms: Add equalizers design tutorial #417

Closed singalsu closed 1 year ago

singalsu commented 2 years ago

This patch adds a section about measuring acoustical speaker frequency response and design of IIR and FIR equalizers to improve it.

Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com

lgirdwood commented 2 years ago

@singalsu can you check CI thanks.

ShriramShastry commented 2 years ago

I'm not sure how the graphs are constructed, even though the target filter response charts are produced; therefore, a brief explanation of the input type and filter type used would be useful.

Thank you !!

marc-hb commented 2 years ago

The build in https://github.com/thesofproject/sof-docs/runs/7148090318?check_suite_focus=true failed because of... some unrelated doxygen copy/paste from @juimonen , see https://github.com/thesofproject/sof/pull/5731#issuecomment-1175630147

Fix submitted in https://github.com/thesofproject/sof/pull/5995, please help review (@juimonen is on vacation)

singalsu commented 1 year ago

@lgirdwood Could someone review this please?

singalsu commented 1 year ago

I'm not sure how the graphs are constructed, even though the target filter response charts are produced; therefore, a brief explanation of the input type and filter type used would be useful.

Thank you !!

Did the text leave to you opens? I know it's harder to review markup language with pictures separately, but the text describes the steps done where the plots were created. Executing with some own tuning case the commands should help explain what happens.

btian1 commented 1 year ago

these are great pictures in frequency domain, and very helpful for audio algorithm developers. Can we follow up with some pictures in time domain with sweep signal, it is more straightforward for non-audio algorithm developers, it will directly show which part of freq was impacted in a sweep signal.

singalsu commented 1 year ago

these are great pictures in frequency domain, and very helpful for audio algorithm developers. Can we follow up with some pictures in time domain with sweep signal, it is more straightforward for non-audio algorithm developers, it will directly show which part of freq was impacted in a sweep signal.

That could be easily added to EQ tool, e.g. just show the resulting lin or log chirp waveform of the design. It would help to understand the dB -> linear amplitude impact.