Closed nnseva closed 7 months ago
commit message is empty and unhelpful
also probably missing sign-off
@cujomalainey, to whom are you addressing?
commit message is empty and unhelpful
also probably missing sign-off
@cujomalainey, to whom are you addressing?
The author, you cannot comment on commit messages directly hence the un-anchored review comment
commit message is empty and unhelpful
also probably missing sign-off
Tried to explain the change. Added my sign-off.
The commit message body in https://github.com/thesofproject/sof-docs/pull/477/commits/d555d7a7646 is still empty. Not a problem for me because the commit message title looks very good to me now and enough for this small fix but there are some people and some policies who insist on non-empty commit messages :-)
fixed --> fix?
some people and some policies who insist on non-empty commit messages :-)
Yes but I won't argue to block it if everyone else is fine
@marc-hb
Please git squash @deb-intel 's fixes and force push a single commit.
done
All reviewer comments now addressed.
The documentation was wrong about getting the quirk default. I've fixed these details.