thesofproject / sof-docs

Documentation for SOF
Other
16 stars 72 forks source link

Fixed suggestions about getting ES8336 quirk default. #477

Closed nnseva closed 7 months ago

nnseva commented 9 months ago

The documentation was wrong about getting the quirk default. I've fixed these details.

deb-intel commented 9 months ago

commit message is empty and unhelpful

also probably missing sign-off

@cujomalainey, to whom are you addressing?

cujomalainey commented 9 months ago

commit message is empty and unhelpful

also probably missing sign-off

@cujomalainey, to whom are you addressing?

The author, you cannot comment on commit messages directly hence the un-anchored review comment

nnseva commented 9 months ago

commit message is empty and unhelpful

also probably missing sign-off

Tried to explain the change. Added my sign-off.

marc-hb commented 9 months ago

The commit message body in https://github.com/thesofproject/sof-docs/pull/477/commits/d555d7a7646 is still empty. Not a problem for me because the commit message title looks very good to me now and enough for this small fix but there are some people and some policies who insist on non-empty commit messages :-)

btian1 commented 9 months ago

fixed --> fix?

cujomalainey commented 8 months ago

some people and some policies who insist on non-empty commit messages :-)

Yes but I won't argue to block it if everyone else is fine

nnseva commented 7 months ago

@marc-hb

Please git squash @deb-intel 's fixes and force push a single commit.

done

lgirdwood commented 7 months ago

All reviewer comments now addressed.