search

thesofproject / sof-test

BSD 3-Clause "New" or "Revised" License
13 stars 46 forks source link

case-lib: remove check for log ldc file #1215

Closed kv2019i closed 4 months ago

kv2019i commented 4 months ago

Checking for ldc (log dictionary) file existance as a way to decide whether to enable or disable logging during a test case, is no longer applicable as SOF supports multiple firmware logging solutions that do not use an ldc file.

Remove the check as it no longer makes sense.

Link: https://github.com/thesofproject/sof-test/issues/1216

kv2019i commented 4 months ago

FYI @marc-hb @lyakh @ssavati @andyross

kv2019i commented 4 months ago

@marc-hb wrote:

This code is useful for stable-v2.2

Please change to:

is_firmware_file_zephyr || ldcFile=$(find_ldc_file) || {

I had this at first, but then started questioning whether adding more conditions makes sense. "is_firmware_file_zephyr" is still heuristics as there's nothing stopping from using sof-logger with Zephyr. So to ease maintainance, why not reduce number of combinations we supprot. I.e. if you want to use sof-test with stable-v2.2 you should have a proper DUT setup with an ldc file to run tests. Period.

kv2019i commented 4 months ago

Btw, this doesn't yet fix the check-sof-logger test case, but this does get FW logs back in other tests.