thesofproject / sof

Sound Open Firmware
Other
541 stars 312 forks source link

[BUG] Component tuning and audio test scripts do not work with topology2 #4522

Closed singalsu closed 12 months ago

singalsu commented 3 years ago

Describe the bug

The Matlab language scripts in tools/tune and tools/test/audio directories do not work with topology2.

To Reproduce Create configuration blob for component or run audio_process_test().

Reproduction Rate

Expected behavior Similar as with topology1

Impact Showstopper for doing new component setup blobs with topology2. Only minimal configuration blobs set for builds needs has been ported.

Environment 1) Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).

Screenshots or console output If applicable, add a screenshot (drag-and-drop an image), or console logs (cut-and-paste text and put a code fence (```) before and after, to help explain the issue.

Please also include the relevant sections from the firmware log and kernel log in the report (and attach the full logs for complete reference). Kernel log is taken from dmesg and firmware log from sof-logger. See https://thesofproject.github.io/latest/developer_guides/debugability/logger/index.html

singalsu commented 2 years ago

There's work in progress PR in #5603. It depends on #5306 also.

singalsu commented 1 year ago

IIR and FIR changes are merged. TDFB, and MFCC are remaining.

kv2019i commented 1 year ago

@singalsu Still on track for V2.5 -- we aim to branch this week?

singalsu commented 1 year ago

TDFB and MFCC won't make it to v2.5. We don't have in IPC4 the controls framework for TDFB (enum, switch). They are missing also from module adapter, so quite a lot work. In MFCC I have not yet figured out use of compressed stream.

lgirdwood commented 1 year ago

@singalsu on track for v2.6 ? or should be moved to v2.7 ?

singalsu commented 1 year ago

@lgirdwood Thanks, I moved to v2.7. We still have many components without IPC4 support, so even if changing the tools and blobs could happen before start of June, we can't test them. One more month looks possible.

lgirdwood commented 1 year ago

@singalsu any update ? how are we trending ?

singalsu commented 1 year ago

@singalsu any update ? how are we trending ?

I've been doing these updates the same time with module API conversions and creating topologies to test them. DC blocker is still without a PR or draft PR. I plan to do it after the crossover and multi-band drc conversions. It's fortunately much smaller effort than these two. One month ETA for all work merged?

alex-cri commented 1 year ago

@singalsu , how have things progressed? Would like to move to 2.8 if remaining effort will take longer than a week.

alex-cri commented 1 year ago

@singalsu , is there an update?

singalsu commented 1 year ago

@singalsu , is there an update?

I think all non-deprecated (*) components have a module adapter and ipc4 PR done. But some are still not yet merged. We miss tplg2 support PRs still for some. The enum control that worked with tplg1 is not yet solved for tplg2. It's however used only by one component (beamformer) that has not been included to signed FW builds.

So all the work (tplg2 support) won't be completed in week so we can move on to 2.8.

(*) We will deprecate now tone generator and selector - turn kconfig off and have warning if enabled.

singalsu commented 12 months ago

All components those have setup script for topology1 now have setup scripts for topology2. This can be closed now!