search

thesofproject / sof

Sound Open Firmware
Other
525 stars 306 forks source link

cmocka: tests should also be able to run on xtensa-qemu #737

Open lgirdwood opened 5 years ago

lgirdwood commented 5 years ago

cmocka tests for xtensa platforms currently run on xt-run emulator. These test should also be to run on qemu too when statically linked with xtensa-newlib.

lgirdwood commented 5 years ago

@xiulipan once working this should be part of CI.

michalgrodzicki commented 5 years ago

@jajanusz what do you think?

jajanusz commented 5 years ago

@jajanusz what do you think?

Everything is possible, but I'd like to have some more info about our qemu: https://github.com/thesofproject/qemu

+what I already wrote #736 - these issues are related

lgirdwood commented 5 years ago

@jajanusz it appears the qemu docs did not transfer over to sof-docs. I will take the action.

jajanusz commented 5 years ago

@lgirdwood @mmaka1 Should w invest time into that? Imo we should stick to one of xt-run or qemu. Supporting both may be extra effort we don't want. At most we should care of 1 simulator + host tests, actively supporting multiple simulators from our side may be too time-consuming. It's not like you just have to run it on qemu. Later we gonna have for example coverage so you'll have to add profiler support for xt-run and gcov somehow to qemu, and it's just DSP, what if we gonna test something more?

lgirdwood commented 5 years ago

@jajanusz I'm happy with xtrun today, but we probably want to keep this feature "open" for the community as this may be useful to run cmocka on non xtensa targets with qemu.