search

thesofproject / sof

Sound Open Firmware
Other
571 stars 321 forks source link

[FEATURE] topology2: nocodec: remove redundant copiers #8975

Open plbossart opened 8 months ago

plbossart commented 8 months ago

Is your feature request related to a problem? Please describe. The nocodec topology exposes redundant intermediate copiers on the SSP input path

sof-mtl-nocodec Screenshot from 2024-03-20 18-04-54

Describe the solution you'd like Removal of those intermediate useless copiers.

lgirdwood commented 7 months ago

@marcinszkudlinski @mwasko do other OSes use the intermediate copiers ? i.e. safe to remove for compatibility reasons. Thanks !

kv2019i commented 6 months ago

FYI @ujfalusi @singalsu -- in context of the "capture pipeline with branches" discussion.

dnikodem commented 6 months ago

@marcinszkudlinski @mwasko do other OSes use the intermediate copiers ? i.e. safe to remove for compatibility reasons. Thanks !

It seems that these additional copiers were added by Bard in change : https://github.com/thesofproject/sof/commit/f6f9b62d5a17a416d203ae531ae652ae131837c2 . It seems that one potential problem they can solve is perhaps different formats for gain type modules?

ujfalusi commented 6 months ago

fwiw, in nocodec configurations we have fixed FE PCM format for all streams and while the modules in paths most of the time have two formats supported, one of them is the (static) FE format. This works around the issue that we cannot handle a module copier which does branching correctly. The format cannot be changed at the branch, if there is need for a change, it has to be done on the branch itself after the module copier.

kv2019i commented 6 months ago

Stable branched for 2.10, nobody assigned to work on this, so moving this to 2.11.

kv2019i commented 3 months ago

No owner -> v2.12