search

thesofproject / sof

Sound Open Firmware
Other
532 stars 307 forks source link

[BUG] PTL doesn't have an open source toolchain, "xtensa-build-zephyr.py ptl" fails by default #9262

Open andyross opened 2 months ago

andyross commented 2 months ago

The PTL platform merged without a toolchain added to the Zephyr SDK for the ace30_ptl SOC, or any other way to create one. This means that builds from a bare tree checkout are always going to fail without access to the Cadence SDK for the device. Also new work that might impact the platform (c.f https://github.com/thesofproject/sof/pull/9261) can't be validated by the submitter.

At the very least, if there's resistance to adding another toolchain to the already huge Zephyr SDK[1] an overlay file should be added to the SOF xtensa-overlays project ( https://github.com/thesofproject/xtensa-overlay ) so that users can build their own.

[1] There are, to be sure, a lot of Xtensa variants in there now.

andyross commented 2 months ago

FWIW: another side band option would be to get partners copies of the relevant Cadence SDK integration files so they could do the work themselves.

abonislawski commented 2 months ago

At the very least, if there's resistance to adding another toolchain to the already huge Zephyr SDK[1]

Do you have this in mind? https://github.com/zephyrproject-rtos/sdk-ng/pull/767

@lgirdwood not sure about the current policy, we should have it also in xtensa-overlay repo or sdk-ng is enough?

lgirdwood commented 2 months ago

At the very least, if there's resistance to adding another toolchain to the already huge Zephyr SDK[1]

Do you have this in mind? zephyrproject-rtos/sdk-ng#767

@lgirdwood not sure about the current policy, we should have it also in xtensa-overlay repo or sdk-ng is enough?

I think CI needs it on SOF side i.e. for GCC front end static analysis for PR testing but IIRC it should all come via Zephyr SDK now.

marc-hb commented 1 month ago

Current GitHub workflows in sof/.github/ use a Zephyr docker image exclusively - because it provides the Zephyr SDK. https://github.com/zephyrproject-rtos/docker-image

kv2019i commented 1 week ago

https://github.com/zephyrproject-rtos/sdk-ng/pull/767 is now merged, so support exists in Zephyr SDK.

No activity on the xtensa-overlay and "ptl" is still marked in extras, so I'll keep this open until we have more clear concensus (either the Zephyr SDK is sufficient for Zephyr native SOF platform and/or xtensa-overlay is updated).