search

thesofproject / sof

Sound Open Firmware
Other
562 stars 319 forks source link

probe: Convert to module API #9629

Closed jsarha closed 2 weeks ago

jsarha commented 3 weeks ago

This commit converts probe debug feature from component to module API.

With this PR the probes does not work without this fix in the Linux side: https://github.com/thesofproject/linux/pull/5221

So its maybe better to wait a bit before merging this? Or what do you say @lgirdwood ?

lgirdwood commented 3 weeks ago

This commit converts probe debug feature from component to module API.

With this PR the probes does not work without this fix in the Linux side: thesofproject/linux#5221

So its maybe better to wait a bit before merging this? Or what do you say @lgirdwood ?

@jsarha kernel fix now merged - pls convert to non draft if ready. Btw, do we need any tooling changes ?

jsarha commented 3 weeks ago

This commit converts probe debug feature from component to module API. With this PR the probes does not work without this fix in the Linux side: thesofproject/linux#5221 So its maybe better to wait a bit before merging this? Or what do you say @lgirdwood ?

@jsarha kernel fix now merged - pls convert to non draft if ready. Btw, do we need any tooling changes ?

Nope, the functionality has not changed.

lgirdwood commented 3 weeks ago

@jsarha can you check CI build results. Breaking Zephyr configs.

jsarha commented 2 weeks ago

Looks good. Some build errors that need to get address before merge, but no blockers otherwise.

The unused variable warning is now fixed, so compile test should be Ok. There is still some device test failures that hardly have anything to do with this PR (the probes are not used in CI tests AFAIK).

kv2019i commented 2 weeks ago

sof-docs fail and Intel LNL fails all known and tracked in https://github.com/thesofproject/sof/issues?q=is%3Aissue+is%3Aopen+label%3ACI