search

thesofproject / sof

Sound Open Firmware
Other
562 stars 319 forks source link

topology2: Add support for cs42l43 SKU with four host DMICs #9666

Closed simontrimmer closed 1 day ago

simontrimmer commented 3 days ago

Add support for another Lenovo SKU that uses cs42l43 and four host side DMICs rather than the CODECs DMICs.

lgirdwood commented 3 days ago

@bardliao pls review.

bardliao commented 3 days ago

The main question is that is the SoundWire DMIC used or not. If not, we need to add a quirk in the machine driver. Like Remove CODEC DMIC for specific SKUs by charleskeepax · Pull Request #5186 · thesofproject/linux And, 'SDW_DMIC_STREAM=Capture-SmartMic' is not needed in that case. If the SoundWire DMIC and the host DMIC coexist, we need to add SDW_DMIC=1

simontrimmer commented 3 days ago

@charleskeepax - I've been having some fun with this today, I'll bother you about it more tomorrow

simontrimmer commented 3 days ago

Hey @bardliao

The main question is that is the SoundWire DMIC used or not. If not, we need to add a quirk in the machine driver. Like Remove CODEC DMIC for specific SKUs by charleskeepax · Pull Request #5186 · thesofproject/linux And, 'SDW_DMIC_STREAM=Capture-SmartMic' is not needed in that case. If the SoundWire DMIC and the host DMIC coexist, we need to add SDW_DMIC=1

I'm pretty certain that we don't have the SoundWire DMIC so will be adding the SOC_SDW_CODEC_MIC quirk when updating the sof_sdw_quirk_table