search

thesofproject / sof

Sound Open Firmware
Other
563 stars 319 forks source link

ext_manifest: include probe information by CONFIG_PROBE #9675

Closed Shawn-Huang724 closed 23 hours ago

Shawn-Huang724 commented 4 days ago

Put probe information into manifest by CONFIG_PROBE=y would be better.

This change could help to avoid annoying kernel log from SOF loader ("unknown sof_ext_man header type 3 size 0x30") if CONFIG_PROBE=n on most SOF machines.

sofci commented 4 days ago

Can one of the admins verify this patch?

reply test this please to run this test once

Shawn-Huang724 commented 4 days ago

Fixes https://github.com/thesofproject

9674.

lyakh commented 4 days ago

test this please

kv2019i commented 4 days ago

Thanks @Shawn-Huang724 -- it's seems this annoyance has gone unfixed for a very long time.

It would seem https://github.com/thesofproject/linux/pull/5183 is probably the best fix. At least for Intel, the new FW releases use IPC4 so will not trigger the warning in IPC3 loader in kernel.

Shawn-Huang724 commented 4 days ago

Thanks @Shawn-Huang724 -- it's seems this annoyance has gone unfixed for a very long time.

It would seem thesofproject/linux#5183 is probably the best fix. At least for Intel, the new FW releases use IPC4 so will not trigger the warning in IPC3 loader in kernel.

Very much agree, it's better for the doer to undo what he has done. [thesofproject/linux#5183] is the best fix of this annoyance in dmesg log. But from the perspective of firmware, this change could increase the integrity and consistency of SOF firmware. This means that the probe information would be not found since the CONFIG_PROBE is disabled in firmware image. Thanks again for your valuable feedback and reviewing.