fix: remove dependencies on Buffer (#24)

thesolarnomad / lora-serialization

LoraWAN serialization/deserialization library for The Things Network

MIT License

164 stars 26 forks source link

fix: remove dependencies on Buffer (#24) #30

Closed avbentem closed 4 years ago

avbentem commented 4 years ago

Fixes #24 (the EcmaScript 5 in TTN Payload Formats do not support Buffer), and gets rid of:

[DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

coveralls commented 4 years ago

Coverage decreased (-0.02%) to 98.909% when pulling 17410ac2b362acd46d7a78c3018ca789b74ca721 on avbentem:master into 6c4d356dcd81747b6b748bdef6b02ef71ec141c5 on thesolarnomad:master.

avbentem commented 4 years ago

Oh well, I guess that decreasing the lines of code also made the coverage drop by a whopping 0.02% :-)

joscha commented 4 years ago

Thanks!