Missing LoraEncoder::getLength()

[matthias-bs]

I am using LoraEncoder instead of LoraMessage, because a statically allocated buffer is perfectly fine for me. Having a getLength() method would be greatly appreciated!

In my application, the data written to the buffer is configuration-dependent and I would like to avoid counting bytes in a second place.

[joscha]

I don't see why we can't have a method like that, do you want to open a pull request?

[matthias-bs]

Sure! Which approach would you prefer: keeping a variable size separately from the buffer or use a variable offset which is also used as follows:

void LoraEncoder::writeUint32(uint32_t i) {
    _intToBytes(_buffer+_offset, i, 4);
    _offset += 4;
}

I would prefer the latter.

[matthias-bs]

Thanks for the ultra quick reply!

[joscha]

I think the offset approach is a tad nicer, as the variable is actually used in all cases instead of carrying it along only for this case?

[matthias-bs]

Thank you very much for accepting the PR. Are you planning a new release soon?

[joscha]

Created 3.2.0 just now.

[matthias-bs]

Yes, but you did not update library.properties... ;-)

[joscha]

3.2.1

[matthias-bs]

Thanks a lot!