search

thesourcerer8 / StdCellLib

LibreSilicon's Standard Cell Library Generator
https://libresilicon.com/
Apache License 2.0
14 stars 8 forks source link

Challenge 1 & 2 #1

Open nikhil2798 opened 4 years ago

nikhil2798 commented 4 years ago

Extraction of the frequency from the log file and converting the frequency in the order of GHz.

PS: I am extremely sorry to upload the wrong file (challenge_1_2.pl) by mistake. The final file is challenge12_final.

thesourcerer8 commented 4 years ago

Please always close filehandles directly after you have used them.

thesourcerer8 commented 4 years ago

Now I tested it, and it errorneously says "Computed maximum clock frequency isn't avaiable in the report." many times.

shivanishah269 commented 4 years ago

As you have written this statement in while loop (Computed maximum clock frequency isn't avaiable in the report.), the statement is getting printed many times because only 1 line will match rest won't. So, I would suggest better write that line outside the while loop.

One more suggestion, take filename as input from the user itself.

nikhil2798 commented 4 years ago

@shivanishah269 I cross checked the while loop error but it is fine when I am running the code without "Computed maximum clock frequency".

Yeah it makes more sense if the user can enter the filename. I have made this change in the code.

Thank you.