thesourcerer8 / altium2kicad

Altium to KiCad converter for PCB and schematics
https://www2.futureware.at/KiCad/
GNU General Public License v2.0
837 stars 153 forks source link

Schematic fixes #38

Closed IJeffray closed 6 years ago

IJeffray commented 6 years ago

Several small but significant improvements to schematic conversion

thesourcerer8 commented 6 years ago

Great! Lots of improvements! Nice! Could you please add warnings for the Ellipses again, so that people know what they have to review?

IJeffray commented 6 years ago

Elliptic arc warnings - wilco (but this is no different to other entities which have some params ignored...) Arcs need more work anyway - I'm looking at this just now, as I've inductors that come out like wobbly worms rather than loops.

thesourcerer8 commented 6 years ago

Ah, we are talking about schematics, I thought this is about PCB. Ok, there I think we don't need warnings for ellipses. But on the other hand, it might be a good idea anyway. I was thinking about PCBs, where I had troubles with octagonal pads, and if I had converted them to a different shape (circle or rectangular), they would have caused short-circuits with neighbor pads, or would have been too small. So the only way out was to warn the users that they must review it since the conversion would most likely cause troubles. If you find anything where missing parameters could cause real problems, feel free to add warnings. I've been thinking about some kind of warning mode, where we add some warning symbols or something so that the place where the warning belongs to can be more easily found.