search

thesourcerer8 / altium2kicad

Altium to KiCad converter for PCB and schematics
https://www2.futureware.at/KiCad/
GNU General Public License v2.0
837 stars 153 forks source link

Testfiles #67

Closed cdwijs closed 5 years ago

cdwijs commented 5 years ago

Added testfiles for the following bugs: https://github.com/thesourcerer8/altium2kicad/issues/62 https://github.com/thesourcerer8/altium2kicad/issues/63 https://github.com/thesourcerer8/altium2kicad/issues/66

thesourcerer8 commented 5 years ago

$SOURCEDESIGNATOR=~s/"/\"/g; does not escape it correctly, I think you need either 2 backslashes or no escaping at all there. The rest of the pull-request looks good to me.

cdwijs commented 5 years ago

I fixed the escaping. Thanks! Cheers, Cedric

thesourcerer8 commented 5 years ago

Thanks a lot!