search

thesourcerer8 / altium2kicad

Altium to KiCad converter for PCB and schematics
https://www2.futureware.at/KiCad/
GNU General Public License v2.0
837 stars 153 forks source link

Print vias without annotate set, add reasonable drill diameter #73

Closed funkobongrip closed 5 years ago

funkobongrip commented 5 years ago

This fixes the #65 "VIA's are not imported" bug for my project. Use with care, as it may break stuff for other Altium projects. Also I have no idea what $annotate is supposed to to.

thesourcerer8 commented 5 years ago

Ok, it seems the $annotate was what removed the VIAs, sorry for that bug. The annotation was meant to be used to add debugging information (annotations) into the output KiCad files, so that you can see the original data and what was converted out of it. Since those annotations can cause very huge files that get too large for KiCad to handle, it is controlled by the $annotate variable.

thesourcerer8 commented 5 years ago

Now my question to all users is: Is that drill diameter a useful addition in this way? What happens with a VIA width of 0.2, that would get a drill diameter of 0, and smaller widths would get negative drill diameters. Does that make sense? I don't have an idea about it at the moment. I would prefer to accept the removal of the $annotate now to fix the bug and to discuss the drill diameter seperately.

funkobongrip commented 5 years ago

For me all vias have a drill diameter == via diameter, yielding no annular ring at all. This was just a quick hack to fix this for me, the correct way would be to extract the via and drill diameter.