thesourcerer8 / hddsuperclone

HDDSuperClone, HDDSuperTool
GNU General Public License v2.0
394 stars 32 forks source link

Remove all network request code, drop unnecessary dependencies. #4

Closed SomeCrazyGuy closed 2 years ago

SomeCrazyGuy commented 2 years ago

This patch removes the dependency on libcurl and openssl. These dependencies are used for fetching and verifying license data as well as create translations for UI elements through google translate. With this patch all code for performing network requests is removed.

thesourcerer8 commented 2 years ago

Why do you want to remove the Google Translate function?

SomeCrazyGuy commented 2 years ago

My rational is that translation and internationalization should be performed using more standard tools -like gettext- which integrates well with GTK applications. If we want to add quick and dirty support for another language with google translate we can use google translate on the .po files generated by gettext.

Maybe we can put this patch on hold and port the code to gettext first?

thesourcerer8 commented 2 years ago

Oh, I didn't noticed that gettext wasn't used. Hmm, yes, porting to gettext first makes sense to me then. But we could already remove the server part which was only used for licensing. Let me know if I should deny this pullrequest.

SomeCrazyGuy commented 2 years ago

Deny this pull request, what I will do is remove the smtp code in one request and submit another pull request to make libcurl an optional dependency. Having a minimal build configuration will make it easier to have a windows port of the viewer build target.