search

thespacedojo / crater.io

HN clone built in Meteor
http://telesc.pe
MIT License
31 stars 10 forks source link

Fix header logo position #1

Closed bengott closed 10 years ago

bengott commented 10 years ago

logo position was wonky between 30em and 40em screen sizes header-logo

Also, it seems goofy to have the source scss files and the resulting CodeKit-generated css files all in source control. I guess there weren't any good Sass packages for Meteor back when Sacha first wrote Telescope? Since this was such a small change, I just manually edited both the source _header.scss and resulting screen.css files. Also, I don't have CodeKit (running Linux here), and I didn't want to regenerate the css with a different Sass preprocessor and introduce a bunch of trivial changes.

Cheers! Ben

bengott commented 10 years ago

I suppose I should submit a PR to the Telescope repo, too, eh?

bengott commented 10 years ago

Submitted to Telescope repo Sep 09. Changes picked up in latest merge.