Closed francescobrivio closed 6 months ago
Thanks for this nice contribution! I've checked on some other models and see consistent improvements as you have shown. The tests are passing too (well, as much as they are passing on master
branch...).
I will therefore merge this!
PR Description
This PR is addressing issue https://github.com/thesps/conifer/issues/66. Main changes:
hlt4ml
(see these lines)backends/xilinxhls/firmware/BDT_unrolled.h
score_t scores
array, from:to
These changes bring a notable improvements in latency (and partially in resource consumption) when using the
AP_SAT
flag in the BDTScorePrecision
, while maintaining performances identical to the current version of conifer in terms of BDT score.Additionally, in commit bffd3a6125e31f68cce29ffefeb1a00d32343b8f I fixed a typo in the "Development instructions" and added
pandas
to thedev_requirements.txt
file.PR Validation
The following tests are done with:
v1.7.5
v2023.2
Latency/Resources table:
master
ap_fixed<11,4,AP_RND_CONV,AP_SAT>
ap_fixed<11,4,AP_RND_CONV,AP_SAT>
master
ap_fixed<11,4,AP_RND_CONV>
ap_fixed<11,4,AP_RND_CONV>
Score plots: