Configurable Keybindings

[ThrosturX]

Almost the same as #610 , except doesn't contain the mode indicator stuff.

[jelly]

This is still all dead code:

termite.cc: At global scope:
termite.cc:1029:13: warning: ‘void move_forward_end_blank_word(VteTerminal*, select_info*)’ defined but not used [-Wunused-function]
 static void move_forward_end_blank_word(VteTerminal *vte, select_info *select) {
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
termite.cc:1025:13: warning: ‘void move_forward_end_word(VteTerminal*, select_info*)’ defined but not used [-Wunused-function]
 static void move_forward_end_word(VteTerminal *vte, select_info *select) {
             ^~~~~~~~~~~~~~~~~~~~~
termite.cc:795:13: warning: ‘long int bottom_row(VteTerminal*)’ defined but not used [-Wunused-function]
 static long bottom_row(VteTerminal *vte) {
             ^~~~~~~~~~
termite.cc:789:13: warning: ‘long int middle_row(VteTerminal*)’ defined but not used [-Wunused-function]
 static long middle_row(VteTerminal *vte) {
             ^~~~~~~~~~
termite.cc:784:13: warning: ‘long int top_row(VteTerminal*)’ defined but not used [-Wunused-function]
 static long top_row(VteTerminal *vte) {
             ^~~~~~~
termite.cc:356:21: warning: ‘const char* binding_get_name(keybinding_cmd)’ defined but not used [-Wunused-function]
 static const char * binding_get_name(keybinding_cmd cmd) {
                     ^~~~~~~~~~~~~~~~
termite.cc: In function ‘void move_to_eol(VteTerminal*, select_info*)’:
termite.cc:2127:1: warning: assuming signed overflow does not occur when changing X +- C1 cmp C2 to X cmp C2 -+ C1 [-Wstrict-overflow]
 }

[jelly]

These are other compiler warnings caused by this change:

                                                                                                                       ^~~~
termite.cc: At global scope:
termite.cc:92:11: warning: no previous declaration for ‘guint vi_mode::parse_mode(const char*)’ [-Wmissing-declarations]
     guint parse_mode ( const char *q )
           ^~~~~~~~~~
termite.cc:129:12: warning: no previous declaration for ‘gchar* vi_mode::to_string(guint)’ [-Wmissing-declarations]
     gchar *to_string ( const guint mode )
            ^~~~~~~~~
termite.cc: In function ‘const char* binding_get_name(keybinding_cmd)’:
termite.cc:359:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
     for (int i = 0; i < num_bindings; ++i) {
                     ~~^~~~~~~~~~~~~~

[ThrosturX]

Hey @jelly , hope you don't mind the mad delays during the summer ;) I don't have access to my workstation right now but I pushed some changes that should address these issues. I'd love to see if there is anything left to complain about, since I'm not in the position to build the project properly right now.

[ThrosturX]

Made some updates. README Updated mostly. Seems like all the compiler errors are there without my patch, so ignoring the ones that are left.

[dsifford]

@jelly What needs to happen for this PR to merge?

[ThrosturX]

Resolved the merge conflict caused by PR #660, this patch already solved that issue so the code was just deleted.

[laktak]

Would this PR allow us to disable the default keybindings like requested in #507?

Why are the defaults set in code instead of a default config file?

[codeclem]

Is this PR missing anything to be merge ready?

[ThrosturX]

Do I understand correctly that the requested change is just an update to README.rst?

[thestinger]

Termite is obsolete. Please use Alacritty instead. See https://github.com/thestinger/termite#termite-is-obsoleted-by-alacritty for more details.