thestinger / termite

Termite is obsoleted by Alacritty. Termite was a keyboard-centric VTE-based terminal, aimed at use within a window manager with tiling and/or tabbing support.
https://github.com/alacritty/alacritty
2.73k stars 240 forks source link

Bold text on light themes #638

Closed aleprovencio closed 5 years ago

aleprovencio commented 5 years ago

Hello, I'm having issues with displaying bold text on light themes, which has already been described here https://github.com/dylanaraps/pywal/issues/175

The conclusion of that thread was a needed update on vte, which I confirmed to work for gnome-terminal but not for termite. I've also tried changing allow_bold without success.

dylanaraps commented 5 years ago

bug report - https://bugzilla.gnome.org/show_bug.cgi?id=793152

commit with fix - https://github.com/GNOME/vte/commit/e9989360bb3b020c4507562af9385ca7584f0d97

egmontkob commented 5 years ago

Do you have foreground_bold defined in your termite config? If so, that color is used for bold text, this isn't overridden by pywal.

aleprovencio commented 5 years ago

Sorry for not testing this option, and it works good enough, thank you. However, as my main concern was pywal's use, I'll be waiting for this https://github.com/dylanaraps/pywal/issues/316