Add cell scaling options

thestinger / termite

Termite is obsoleted by Alacritty. Termite was a keyboard-centric VTE-based terminal, aimed at use within a window manager with tiling and/or tabbing support.

https://github.com/alacritty/alacritty

2.73k stars 240 forks source link

Add cell scaling options #657

Closed richard closed 5 years ago

richard commented 5 years ago

Add a line_height_scale option to correspond to vte_terminal_set_cell_height_scale introduced in GNOME/vte@26c79c6.

See issues #209 and #232

dtzWill commented 5 years ago

FWIW I've been doing more or less the same thing and it seems to work properly?

Wasn't 100% changing these scales didn't interfere with something (like size_hints calculations and reporting?) but if we're introducing the one might as well the other?

https://gist.github.com/dtzWill/114c9f986a623baa05d7e85abbaa66b9

I have small preference to keep the option names I was using O:), but only because it aligns with the API it controls. But either naming works for me!

richard commented 5 years ago

Thanks for the feedback and sharing your patch, it has been working well for me too. Agreed on the naming and inclusion of the width option.

jelly commented 5 years ago

Merged via 4aa842245f7abb9328bf37d48f814c7b749e8516