search

thestinger / termite

Termite is obsoleted by Alacritty. Termite was a keyboard-centric VTE-based terminal, aimed at use within a window manager with tiling and/or tabbing support.
https://github.com/alacritty/alacritty
2.74k stars 241 forks source link

Require Control to be pressed to open URLs #697

Closed foxcpp closed 3 years ago

foxcpp commented 4 years ago

This code keeps track of whether Control is pressed (updated in key_press_cb and key_release_cb). Flag is used in button_press_cb.

config_info is not the best place for that flag (by looking at name), though, but it is shared between key_press_cb and button_press_cb so it was an obvious choice.

Looking for feedback, I am not sure whether it is worth adding a configuration option to switch between old and new behavior.

Closes #525. (see https://github.com/thestinger/termite/issues/525#issuecomment-486565092)

ifohancroft commented 4 years ago

I don't think we need a switch. Just having to Ctrl+click on a url to open it, is good enough IMO.

gattazr commented 4 years ago

I'm sorry for bumping this thread without adding anything to the conversation but is there something blocking the review and / or the release of this pull request ?

I would really enjoy this new behavior :sweat_smile:

foxcpp commented 4 years ago

I'm sorry for bumping this thread without adding anything to the conversation but is there something blocking the review and / or the release of this pull request ?

No idea.

@thestinger can we get a blessing from you?

thestinger commented 4 years ago

I don't maintain Termite or actively work on it. I handed things off to @jelly but maybe I need to find someone else to take it over. I don't have any time available for it and can't start spending my time working on it.

ifohancroft commented 4 years ago

I'd love to take it over (just saying)

thestinger commented 3 years ago

Termite is obsolete. Please use Alacritty instead. See https://github.com/thestinger/termite#termite-is-obsoleted-by-alacritty for more details.