search

thestinger / termite

Termite is obsoleted by Alacritty. Termite was a keyboard-centric VTE-based terminal, aimed at use within a window manager with tiling and/or tabbing support.
https://github.com/alacritty/alacritty
2.74k stars 241 forks source link

bidi support #713

Closed itielsa closed 3 years ago

itielsa commented 4 years ago

I saw that VTE has add bidi support, as did gnome-terminal. [https://gitlab.gnome.org/GNOME/vte/issues/53]() since termite is a VTE-based terminal, is there a way to add bidi-support to termite as well? if someone would want to direct me, maybe I will try to implement that myself. I don't have any experience with gtk/vte but i know my way in c++.

akiva commented 4 years ago

Any news on this? I would greatly welcome bi-directional support. I love Termite, but it's the one thing that has been nagging me to consider alternatives.

egmontkob commented 4 years ago

vte-ng is a few small changes on top of official vte (0.56.2 thereof at the moment). These changes do apply and compile on top of mainstream vte-0.58.x (which has BiDi), too. Give it a try, I think it should work.

akiva commented 4 years ago

I am running termite 15.1 and vte 0.58.3.1 at the moment and I am not seeing any difference (ie. if I create a file called שלום.txt, it still displays reversed).

egmontkob commented 4 years ago

Make sure your vte(-ng) was compiled with bidi support enabled (requires fribidi devel package >= 1.0).

egmontkob commented 4 years ago

Mind you, there is no vte-ng 0.58.x available at the moment (and by the way, there isn't any upstream vte-0.58.3.1 either, not sure where that .1 comes from). Also Termite cannot use mainstream vte, it can only use vte-ng. So are you absolutely sure you created vte-ng 0.58 for yourself as per the instructions above, and use that? Does echo $VTE_VERSION in your Termite give 58xx?

akiva commented 4 years ago

@egmontkob I accidentally included the 0.58.3-1 version Arch is reporting as installed as 0.58.3.1. As for the version of termite, I have the Arch community repo version installed. There is no specific AUR for vte-ng, it's all handled automatically by default pacman settings for the community install. However, when I run the echo command, it reports 5602 (even though my system is up-to-date). :/

Narrat commented 4 years ago

Well since this commit https://git.archlinux.org/svntogit/community.git/commit/trunk?h=packages/termite&id=4bcec16ea6f3c34df5d6e1882fd7c17f11354c5b there is no separate vte-ng package in Arch anymore. So you would need to take some more steps to make sure you have a termite version with a recent vte-ng version.

BarbUk commented 4 years ago

Termite package from community is build with a static vte-ng 0.56: see: https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/termite#n14

I'm going to flag the package to ask an update of vte-ng.

So you would need to take some more steps to make sure you have a termite version with a recent vte-ng version.

travankor commented 4 years ago

It would be nice if termite had better default build support for static compilation -- AFAIK no one except termite uses vte-ng.

Something like what the Arch package already does but instead with a vendored submodule of vte-ng and a build flag for static building in the makefile.

egmontkob commented 4 years ago

static compilation

https://gitlab.gnome.org/GNOME/vte/issues/148

itielsa commented 4 years ago

I follow @BarbUk suggestion and it worked. Thanks!

akiva commented 4 years ago

Fixed by simply getting the latest via AUR.

thestinger commented 3 years ago

Termite is obsolete. Please use Alacritty instead. See https://github.com/thestinger/termite#termite-is-obsoleted-by-alacritty for more details.