A set of C++ classes that provide a common API for realtime audio input/output across Linux (native ALSA, JACK, PulseAudio and OSS), Macintosh OS X (CoreAudio and JACK), and Windows (DirectSound, ASIO, and WASAPI) operating systems.
Other
1.49k
stars
317
forks
source link
some tests use signed long instead of int32_t causing issues on 64-bit systems #420
typedef long int MY_TYPE;
#define FORMAT RTAUDIO_SINT32
become problematic on 64-bit systems, or more in general wherever long int is not 32 bits.
There are two instances of this in tests/duplex.cpp and tests/playsaw.cpp and tests/record.cpp, but they were commented out, so wouldn't get caught by tests. Other tests use signed int instead which may be OK, but I'd suggest to have all the types be explicit using fixed-width integers from stdint.h.
Idioms such as:
become problematic on 64-bit systems, or more in general wherever
long intis not 32 bits.There are two instances of this in
tests/duplex.cppandtests/playsaw.cppandtests/record.cpp, but they were commented out, so wouldn't get caught by tests. Other tests usesigned intinstead which may be OK, but I'd suggest to have all the types be explicit using fixed-width integers fromstdint.h.