thesunshade / citation-helper

Lookup citations quickly and find suttas on major websites
2 stars 1 forks source link

Links broken to Sutta Central Khandhaka #32

Closed Kaccana-Bhikkhu closed 1 year ago

Kaccana-Bhikkhu commented 1 year ago

Thank you very much for creating such a useful tool. I'm planning to use links to sutta.readingfaithfully.org in a Dhamma project, and noticed a minor but annoying bug.

On the live https://sutta.readingfaithfully.org site, Kd links to Sutta Central are missing a '/', which breaks the link. For example the page:

https://sutta.readingfaithfully.org/?q=Kd-1.14 contains the link:

https://suttacentral.netpli-tv-kd1/en/sujato (broken)

adding '/' yields:

https://suttacentral.net/pli-tv-kd1/en/sujato (works, although it doesn't yet link to section 14)

Hopefully this can be fixed the next time you update the website.

All good wishes,

thesunshade commented 1 year ago

https://suttacentral.netpli-tv-kd1/en/sujato (broken)

Thank you so much! It should be fixed now.

(works, although it doesn't yet link to section 14)

I don't really have any plans to support that. If by section 14 you mean the 14th item in the table of contents, that's tricky. The way SC represents that in the url is #pli-tv-kd1:23.1.0. So I'd have to make a table to make correspondents between the sections in the TOC and the real SC segments. And then I'd have to have a way in the interface so that the user would be able to indicate that the number they were using was for the TOC section and not the SC section.

I'm open to ideas, but I'm not sure it's worth it.

That said, I'd love to hear how you are using the tool. Being able to link to the tool itself with a particular citation was kind of an afterthought. It's useful for linking to suttas since there can be so many alternative translations. But for the Vinaya there is just the one.

Kaccana-Bhikkhu commented 1 year ago

Thank you for fixing this problem so quickly. And I agree that linking to specific sections of the Vinaya is low priority. Direct links to SuttaCentral or dhammatalks.org are sufficient.

The project I'm working on is a tagged archive of my preceptor's audio questions, answers, and stories. It's located at https://github.com/Kaccana-Bhikkhu/qs-archive. The prototype website doesn't yet show the links to readingfaithfully, but the version2 branch should be live in a week or two. After I update the website, you can look at the event "Tudong Stories at Spirit Rock" for an example of links to readingfaithfully suttas.

Thank you again for making this valuable resource available.

thesunshade commented 1 year ago

Ah, then I believe you are the venerable one I know from Abhayagiri. I was at your samanera ordination.

Please drop me a line when you have a chance. info@readingfaithfully.org