search

thetanz / OpenFeature-al

OpenFeature for AL transforms Application Areas into feature toggles.
https://theta.co.nz
GNU Lesser General Public License v3.0
21 stars 5 forks source link

Deleting a feature flag does not disable functionality #1

Closed spookymattress closed 3 years ago

spookymattress commented 3 years ago

I have created a feature flag called "MyFeat" and enabled it. Works fine!

When I delete the feature flag, the functionality is still active. Shouldn't it be disabled? Or what is the intended behaviour?

vody commented 3 years ago

@spookymattress, looks like that app recalculates a flag only if you manually delete a condition: https://github.com/thetanz/featureflags-al/blob/5b34891c5f2e88e5bdf20633efe10ea5b1d2be3b/MAIN/src/table/FeatureFlag.Table.al#L78 https://github.com/thetanz/featureflags-al/blob/5b34891c5f2e88e5bdf20633efe10ea5b1d2be3b/MAIN/src/codeunit/FeatureFlagMgt.Codeunit.al#L139 Thank you for this feedback. Will work out a fix for this.

vody commented 3 years ago

@spookymattress, could you please validate a latest version, so will close as confirmed.