Closed azmy60 closed 10 months ago
Latest commit: 359dfd38606b1e2888143d03c79ac064aa05e82f
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
I'm glad you like it! Setting up the devtools was the trickiest one since there was really no documentation about it, and I had to do the research from both playwright & puppeteer repo, it was quite trial and errors.
And I think it wouldn't be hard to have both overlay and the extension configs running. I'll update you once I finish.
I'm having some obscure errors while trying to run the tests locally. I have a feeling this is not gonna be fun debugging.. 😅
Yeah, I just noticed some of the tests are flaky after several runs. :disappointed:
@thetarnav I've added a little patch. I ran it 100 times and looked good in my local. Could you test it on your local again 😅? Hopefully it's fixed by now.
Ok I've tried this again, switched to linux in the meantime, and everything works great. Thank you again for helping me with this and sorry for the delay. Playwright looks like a really nice tool to use once it actually works 😊
Hopefully this is enough for a basic E2E test setup https://github.com/thetarnav/solid-devtools/issues/223. I've added just a couple of tests as well. Let me know if there are things that need to change or add. This is my first time setting up playwright and GitHub workflow :innocent: