search

thetarnav / solid-devtools

Library of developer tools, reactivity debugger & Devtools Chrome extension for visualizing SolidJS reactivity graph
https://chrome.google.com/webstore/detail/solid-devtools/kmcfjchnmmaeeagadbhoofajiopoceel
MIT License
536 stars 21 forks source link

Detect solid-js via ANY element with "data-hk" #297

Closed indeyets closed 5 months ago

indeyets commented 5 months ago

This approach is much more reliable and speed difference should be irrelevant as it happens one time on start and is still very fast.

Current solid-start (0.7.x, 1.0.x) doesn't hydrate "first child", and is usually applied only to the custom root.

p.s. also, I removed .js/.jsx extensions from eslint check, as eslint gave me error about lack of such files in repository.

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 358a15e43d73084ba68d3fd57af7e894d467de03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR