search

thetatoken / theta-infrastructure-ledger-explorer

Explorer for the Theta Ledger
https://docs.thetatoken.org/
MIT License
57 stars 26 forks source link

Allow to choose between HTTP and HTTPS during deployment time #24

Closed pedroshaina closed 3 years ago

pedroshaina commented 3 years ago

Most of the modern software stack doesn't handle HTTPS/SSL on the application side but rather on the proxy/gateway level as most likely the application itself won't even be exposed to the internet. With that in mind, most people won't benefit from the existing HTTP2/HTTPS implementation currently in place using the SPDY protocol.

This PR aims to use the already existing config param in order to allow the explorer API to be exposed as plain HTTP using the already existing express instance of the application.

Please, if there are any guidelines on contributions for this project and this PR somehow hurt any of them, let me know and I'll be more than happy to accomodate the changes in my PR.

Also, if this doesn't make sense at all, I'd like to hear the reasoning behind it =)

Thanks.

zhenyang-sliver commented 3 years ago

This feature is already supported in master branch.