thetawavegame / thetawave

A physics based, space shooter game made with Rust and the Bevy engine.
https://thetawave.metalmancy.tech
MIT License
159 stars 9 forks source link

Start adding a warning for using firefox over chrome. #182

Open varoonp123 opened 2 months ago

varoonp123 commented 2 months ago

We want to discourage firefox because wasm and audio seem to work better on chrome and are pretty bad right now in firefox.

@LordDeatHunter can you provide some input on the html+css? I probably should have run prettier in a separate commit. I am not so comfortable with front end stuff. Screenshot from 2024-04-22 23-39-27

LordDeatHunter commented 2 months ago

I sent you updated files on discord, since I can't modify your fork :)

varoonp123 commented 2 months ago

If you can, make a PR from a branch on your fork :)

LordDeatHunter commented 2 months ago

varoonp123/thetawave#2 Hopefully this is what you meant 😄 tho IMO it's a bit extra unnecessary effort making a fork of a fork.

edit: Updated image for reference: image

edit 2: i posted a screenshot instead of a vid, there's also a "pulsing" animation on the red part background, as well as some effects on the 2 buttons (chrome link and close)

varoonp123 commented 2 months ago

@LordDeatHunter Looks great! Much better than what my backend brain could do on my own.

  1. I tried but was unable to make the red box a tad smaller so that it doesnt cover the top of the "Thetawave" logo/gif.
  2. How do yall feel about using an "x" icon instead of writing out "Close" and a "warning" icon heroicons are pretty decent and free

I meant make a PR from your fork into the main repo.

# HTTPS is fine because you dont need to push directly to the main repo. HTTPS let you read/clone but 
# DOES NOT let you push to their repo
git clone https://github.com/thetawavegame/thetawave.git && cd thetawave
git remote add vp https://github.com/varoonp123/thetawave.git 
git remote add cds https://github.com/cdsupina/thetawave.git 

# THIS MUST BE SSH/git so you can push to your fork
git remote add dh git@github.com:LordDeatHunter/thetawave.git

# Pulls in recent branches/commits into the local git db whenever you want them
# but doesnt make any changes to your local repo. I fetch right before I want to branch
git fetch vp
git fetch dh
git fetch cds
git fetch origin

# Branch off of me with a new branch name. I use the `-b` a ton
git checkout -b ui/chromeWarningAssist remotes/vp/ui/chromeWarning
echo "Do the things and commit"

# Push to your fork. Then you can PR into the thetawavegame/thetawave repo.
# You can also PR from your fork into ANY fork of the main repo 
git push dh ui/chromeWarningAssist
LordDeatHunter commented 2 months ago
  1. I don't think this is that big of an issue, considering that you kinda need to close the popup before continuing. I can still shrink it a bit if you'd like?
  2. Sure, I can see what fits
  3. Ah, that works 😅 I find it more convenient with branches, but sure, I can redirect the merge target of the other PR.