search

thetensor-space / thetensor-space.github.io

Tools to Tame the Tensor
https://TheTensor.Space
MIT License
3 stars 4 forks source link

Bug fix: KaTex works in production #48

Closed Alex-Cannon closed 4 years ago

Alex-Cannon commented 4 years ago

Close #46

Okay, after some effort, I figured this out. I had to create custom scripts to find KaTex delimiters (The $$ katex $$ signs) and manually use the KaTex API.

I'm confident this will work in production, but it is untested.

I replaced KaTex with Mathjax. I wasn't sure why katex wasn't working, so I swapped us over to mathjax.

After some research, I learned MathJax and KaTex accept the same input LaTeX / TeX (and do exactly the same thing), only katex is more efficient.

All of our previous functionality is the same, and as an author, you wouldn't notice much of a difference. I confirmed this works in production.

algeboy commented 4 years ago

This isn’t a good idea. MathJax has terrible fonts. I would much prefer KaTEX

On Sat, Jan 4, 2020 at 10:54 AM Alex Cannon notifications@github.com wrote:

@Alex-Cannon https://github.com/Alex-Cannon requested your review on:

48 https://github.com/thetensor-space/thetensor-space.github.io/pull/48

Bug fix: Replaced KaTex with Mathjax.

— You are receiving this because your review was requested.

Reply to this email directly, view it on GitHub https://github.com/thetensor-space/thetensor-space.github.io/pull/48?email_source=notifications&email_token=AFS7BD7QJ5544MJB3NKQWEDQ4DEOXA5CNFSM4KCXEWK2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVYU2RSY#event-2921965771, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFS7BD7FS2CYUYCX3KYEZK3Q4DEOXANCNFSM4KCXEWKQ .

Alex-Cannon commented 4 years ago

@algeboy would you read my comments above? We're good to merge now.